From fabb77d98d8459d91592cf6ada0f22ce47fb0ffb Mon Sep 17 00:00:00 2001
From: alikia2x <alikia2x@outlook.com>
Date: Sat, 22 Mar 2025 00:28:47 +0800
Subject: [PATCH] fix: inefficient SQL query for getting songs close to
 milestone

---
 lib/db/snapshot.ts | 53 +++++++++++++++++++---------------------------
 1 file changed, 22 insertions(+), 31 deletions(-)

diff --git a/lib/db/snapshot.ts b/lib/db/snapshot.ts
index 5921059..9f8cee4 100644
--- a/lib/db/snapshot.ts
+++ b/lib/db/snapshot.ts
@@ -5,40 +5,31 @@ import { parseTimestampFromPsql } from "lib/utils/formatTimestampToPostgre.ts";
 
 export async function getSongsNearMilestone(client: Client) {
 	const queryResult = await client.queryObject<VideoSnapshotType>(`
-    	WITH max_views_per_aid AS (
-			-- 找出每个 aid 的最大 views 值，并确保 aid 存在于 songs 表中
-			SELECT 
-				vs.aid, 
-				MAX(vs.views) AS max_views
-			FROM 
+    	WITH filtered_snapshots AS (
+			SELECT
+				vs.*
+			FROM
 				video_snapshot vs
-			INNER JOIN 
-				songs s
-			ON 
-				vs.aid = s.aid
-			GROUP BY 
-				vs.aid
+			WHERE
+				(vs.views >= 90000 AND vs.views < 100000) OR
+				(vs.views >= 900000 AND vs.views < 1000000)
 		),
-		filtered_max_views AS (
-			-- 筛选出满足条件的最大 views
-			SELECT 
-				aid, 
-				max_views
-			FROM 
-				max_views_per_aid
-			WHERE 
-				(max_views >= 90000 AND max_views < 100000) OR
-				(max_views >= 900000 AND max_views < 1000000)
+		ranked_snapshots AS (
+			SELECT
+				fs.*,
+				ROW_NUMBER() OVER (PARTITION BY fs.aid ORDER BY fs.created_at DESC) as rn,
+				MAX(fs.views) OVER (PARTITION BY fs.aid) as max_views_per_aid
+			FROM
+				filtered_snapshots fs
+			INNER JOIN
+				songs s ON fs.aid = s.aid
 		)
-		-- 获取符合条件的完整行数据
-		SELECT 
-			vs.*
-		FROM 
-			video_snapshot vs
-		INNER JOIN 
-			filtered_max_views fmv
-		ON 
-			vs.aid = fmv.aid AND vs.views = fmv.max_views
+		SELECT
+			rs.id, rs.created_at, rs.views, rs.coins, rs.likes, rs.favorites, rs.shares, rs.danmakus, rs.aid, rs.replies
+		FROM
+			ranked_snapshots rs
+		WHERE
+			rs.rn = 1;
     `);
 	return queryResult.rows.map((row) => {
 		return {